Skip to content

repo_search_commits: removing client-side-filters and updating the capabilities of the tool#1360

Merged
danhellem merged 12 commits into
microsoft:mainfrom
krid-583:users/krid/repo-search-commits-description-fix
Jul 1, 2026
Merged

repo_search_commits: removing client-side-filters and updating the capabilities of the tool#1360
danhellem merged 12 commits into
microsoft:mainfrom
krid-583:users/krid/repo-search-commits-description-fix

Conversation

@krid-583

@krid-583 krid-583 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Migrates the repo_search_commits tool from the Git REST API
(GET _apis/git/repositories/{repo}/commits) to the Azure DevOps
Search API (POST almsearch.dev.azure.com/_apis/search/commitSearchResults).

GitHub issue number

Closes #1327

Associated Risks

None

PR Checklist

  • I have read the contribution guidelines
  • I have read the code of conduct guidelines
  • Title of the pull request is clear and informative.
  • 👌 Code hygiene
  • 🔭 Telemetry added, updated, or N/A
  • 📄 Documentation added, updated, or N/A
  • 🛡️ Automated tests added, or N/A

🧪 How did you test it?

Tested the updated unit tests.

  1. Test Suites: 18 passed, 18 total
  2. Tests: 987 passed, 987 total

Manually tested the tool.

image image

@krid-583 krid-583 requested a review from a team as a code owner June 15, 2026 06:22
Comment thread src/tools/repositories.ts Outdated
@krid-583 krid-583 changed the title repo_search_commits: clarify client-side vs server-side filtering in parameter descriptions repo_search_commits: removing client-side-filters Jun 23, 2026
@krid-583 krid-583 changed the title repo_search_commits: removing client-side-filters repo_search_commits: removing client-side-filters and updating the capabilities of the tool Jun 29, 2026

@dpaquette dpaquette left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how much simpler this tool becomes. Just need to improve the argument descriptions a little

Comment thread src/tools/repositories.ts Outdated
dpaquette
dpaquette previously approved these changes Jun 30, 2026
danhellem
danhellem previously approved these changes Jul 1, 2026
@codecov-commenter

codecov-commenter commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@1522701). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/tools/repositories.ts 95.23% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage        ?   92.77%           
=======================================
  Files           ?       19           
  Lines           ?     2173           
  Branches        ?      516           
=======================================
  Hits            ?     2016           
  Misses          ?       72           
  Partials        ?       85           
Flag Coverage Δ
unittests 92.77% <95.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krid-583 krid-583 dismissed stale reviews from danhellem and dpaquette via 026e874 July 1, 2026 13:06
@danhellem danhellem merged commit 6652c96 into microsoft:main Jul 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: repo_search_commits searchText not passed to API as searchCriteria.messageContains

4 participants